-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification pipeline boilerplate #126
Conversation
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 24 +2
Lines 900 939 +39
=========================================
+ Hits 900 939 +39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm out of the office unexpectedly, but plan to be back this Thursday, Sept 7. I can take a closer look when I return. In the meantime, can you give me some direction about what kind of review you'd like? I gather that you'd like me to write the code that run_verification.run will execute? If so, I can look at this PR from the perspective of understanding how to do that. Are there other things you'd like me to look at?
Our general guidelines and philosophy on code reviews are in this wiki entry: https://github.com/lincc-frameworks/docs/wiki/Design-and-Code-Review-Policy I'm hoping that by getting this boilerplate PR out of the way, adding the meaningful implementation of the verification logic will be more straightforward. Your assumption of the perspective I'm looking for is correct, though I'm planning to also contribute some to the logic in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments below, but overall LGTM and I'll approve and let you decide when you're ready to merge.
tests/hipscat_import/verification/test_verification_arguments.py
Outdated
Show resolved
Hide resolved
* Use minimum stage name formatting. * Run copier. * Add a tad more context for failure email. * Pin pandas version * Remove benchmarks for now. * unpin sphinx versions (#134) --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com>
* unpin sphinx versions (#134) * Verification pipeline boilerplate (#126) * Verification pipeline boilerplate * Input catalog options. * Contribution docs updates. * Merge recent changes (#135) * Use minimum stage name formatting. * Run copier. * Add a tad more context for failure email. * Pin pandas version * Remove benchmarks for now. * unpin sphinx versions (#134) --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com> --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com> * Check for valid catalog directories. (#136) * Check for valid catalog directories. * Hit uncovered file check. --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com>
Change Description
Adds the boilerplate for running the new verification pipeline within the existing hipscat-import pipeline infrastructure.
This allows us to inherit:
Code Quality
New Feature Checklist