Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass storage options to read/write operations. #178

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Addresses issues introduced from testing in #177 .

cloud tests will be added to https://github.com/astronomy-commons/hipscat-cloudtests in upcoming PRs.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a476a8) 99.91% compared to head (b42be80) 99.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   99.91%   99.76%   -0.16%     
==========================================
  Files          27       27              
  Lines        1164     1257      +93     
==========================================
+ Hits         1163     1254      +91     
- Misses          1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/hipscat_import/runtime_arguments.py Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit f50adee into main Dec 6, 2023
10 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/118/cloud branch December 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants