Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort _hipscat_index column #243

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Sort _hipscat_index column #243

merged 4 commits into from
Feb 28, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #179, closes #180

Solution Description

  • Explicitly either creates a new hipscat index, uses an existing hipscat index, or doesn't do anything with hipscat_index.
  • Clumps the functionality under fewer conditionals so the flow of the method is cleaner.
  • Sets pandas index to hipscat_index when using existing values and sorts.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (b571ef8) to head (4f1b3ef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          24       24           
  Lines        1203     1204    +1     
=======================================
+ Hits         1200     1201    +1     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/hipscat_import/catalog/map_reduce.py Outdated Show resolved Hide resolved
Co-authored-by: Sandro Campos <scampos@andrew.cmu.edu>
@delucchi-cmu delucchi-cmu merged commit c5af8dd into main Feb 28, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/179/index branch February 28, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pandas index column to metadata Sort by HiPSCat index if use_hipscat_index=True
2 participants