Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop duplicates in leaf files during SOAP. #250

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

For most association between source-and-object, the two id values will be the same (since that's how we're finding the associations anyway). We don't need to keep those duplicate values around, and don't need to keep the source_id values around either.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (ea60042) to head (be001bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          24       24           
  Lines        1204     1204           
=======================================
  Hits         1201     1201           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 9d0bfc4 into main Mar 6, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/soap branch March 6, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants