Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a subset of pixels when creating a margin cache. #323

Merged
merged 7 commits into from
May 31, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #312

Adds an argument to explicitly limit the margin generation with a subset of pixels in the primary catalog. Since this is primarily useful when debugging, the argument name reflects that.

NB: This requires changes to provenance info JSON serialization that will be included in astronomy-commons/hats#279.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (53b4b0f) to head (1258181).
Report is 49 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          26       26           
  Lines        1372     1379    +7     
=======================================
+ Hits         1366     1373    +7     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from camposandro May 31, 2024 17:51
@delucchi-cmu delucchi-cmu merged commit 277d801 into main May 31, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/312/subset branch May 31, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate margin cache for catalog subset
2 participants