Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open files with "b" flag #407

Closed
1 of 3 tasks
hombit opened this issue Oct 31, 2024 · 0 comments · Fixed by #419
Closed
1 of 3 tasks

Open files with "b" flag #407

hombit opened this issue Oct 31, 2024 · 0 comments · Fixed by #419
Assignees
Labels
bug Something isn't working

Comments

@hombit
Copy link
Contributor

hombit commented Oct 31, 2024

Bug report

File readers in file_io should open files with "rb" mode, e.g. here:

with file_pointer.open("r", **kwargs) as csv_file:

Fixing this issue should also fix this one: astronomy-commons/hats-import#425

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a description of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
@hombit hombit added the bug Something isn't working label Oct 31, 2024
@nevencaplar nevencaplar moved this to Todo in HATS / LSDB Nov 14, 2024
@delucchi-cmu delucchi-cmu self-assigned this Nov 14, 2024
@delucchi-cmu delucchi-cmu moved this from Todo to In Progress in HATS / LSDB Nov 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in HATS / LSDB Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants