Capture compression and open binary if present. #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compression
kwarg, when provided, should be used when opening the file, but should NOT be passed along topandas.read_csv
. This captures the value in a named argument so it can be used in the file opening.Further, if some compression is provided, we change the read mode to
"rb"
, as compression implies that the underlying file is not plain text.Closes #407
Closes astronomy-commons/hats-import#425