Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting Improvements #424

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Plotting Improvements #424

merged 3 commits into from
Nov 19, 2024

Conversation

smcguire-cmu
Copy link
Contributor

  • add color_by_order option to plot_pixel_list to allow plotting pixels without coloring the tiles by order
  • Change behavior to plot on existing axes if they exist and are valid

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.03%. Comparing base (c27133d) to head (0971802).
Report is 15 commits behind head on margin.

Files with missing lines Patch % Lines
src/hats/inspection/visualize_catalog.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           margin     #424   +/-   ##
=======================================
  Coverage   93.02%   93.03%           
=======================================
  Files          47       47           
  Lines        2123     2140   +17     
=======================================
+ Hits         1975     1991   +16     
- Misses        148      149    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Before [c27133d] After [379a2db] Ratio Benchmark (Parameter)
12.8±0.9ms 13.5±0.9ms 1.06 benchmarks.Suite.time_inner_pixel_alignment
1.02±0.01ms 1.03±0.02ms 1.01 benchmarks.time_test_cone_filter_multiple_order
385±3ms 385±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
110±1ms 110±0.6ms 1 benchmarks.Suite.time_paths_creation
45.8±0.2ms 45.7±0.4ms 1 benchmarks.Suite.time_pixel_tree_creation
124±0.4ms 124±2ms 1 benchmarks.time_test_alignment_even_sky
22.6±0.1ms 22.5±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
93.1±0.4ms 91.9±0.6ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
93.4±0.4ms 92.3±1ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info

Click here to view all benchmarks.

@smcguire-cmu smcguire-cmu changed the base branch from main to margin November 19, 2024 20:45
@smcguire-cmu smcguire-cmu merged commit c5605d5 into margin Nov 19, 2024
11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/plotting-improvements branch November 19, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants