Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace healpix with cdshealpix for pixel math operations #430

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Nov 20, 2024

Removes healpy in healpix pixel math operations

fixes #423

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (a87875e) to head (f495c43).
Report is 11 commits behind head on margin.

Additional details and impacted files
@@            Coverage Diff             @@
##           margin     #430      +/-   ##
==========================================
+ Coverage   92.87%   92.96%   +0.09%     
==========================================
  Files          46       46              
  Lines        2034     2075      +41     
==========================================
+ Hits         1889     1929      +40     
- Misses        145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/hats/pixel_math/healpix_shim.py Outdated Show resolved Hide resolved
src/hats/pixel_math/healpix_shim.py Outdated Show resolved Hide resolved
src/hats/pixel_math/healpix_shim.py Show resolved Hide resolved
Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address pylint finding. Otherwise LGTM.

@smcguire-cmu smcguire-cmu merged commit 14ac56d into margin Nov 22, 2024
9 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/healpy-math branch November 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants