Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style testing #165

Merged

Conversation

WilliamJamieson
Copy link
Contributor

Adds:

  • fylnt testing (modernizes all strings)
  • pyproject-fmt and validate-pyproject testing (lints the pyproject.toml file)

Removes:

  • pyupgrade (ruff now fully replaces it)
  • bandit (ruff now fully replaces it)

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #165 (83b05a0) into main (1b40863) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   98.53%   98.84%   +0.31%     
==========================================
  Files          52       52              
  Lines        1909     1909              
==========================================
+ Hits         1881     1887       +6     
+ Misses         28       22       -6     
Impacted Files Coverage Δ
asdf_astropy/converters/transform/properties.py 91.11% <0.00%> (-8.89%) ⬇️
...tropy/converters/transform/tests/test_transform.py 96.41% <0.00%> (+0.71%) ⬆️
asdf_astropy/converters/transform/core.py 98.31% <0.00%> (+6.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

`ruff` now can entirely replace `pyupgrade` so this is redundant.
`ruff` is feature complete for `bandit` testing, so running `bandit` is redundant.
@WilliamJamieson WilliamJamieson force-pushed the feature/update_style_checks branch from e43f337 to 83b05a0 Compare February 15, 2023 14:35
@WilliamJamieson WilliamJamieson merged commit 23131e6 into astropy:main Feb 15, 2023
@WilliamJamieson WilliamJamieson deleted the feature/update_style_checks branch February 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants