-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First tutorial in specutils series #491
base: main
Are you sure you want to change the base?
Conversation
trying to bring my material up-to-date with astropy-tutorials main
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,475 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation for calling it xid
. Is there a more descriptive variable name we could use?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about crossmatch_id
?
Hi @eblur and @kelle, I realize this PR is from a few years ago, but it looks like the tutorial is complete and the review is effectively resolved. If the tutorial is still something you'd like to merge, I think it would just need to be updated with more recent versions of the dependencies (I tried simply to run the notebook with recent versions and it failed). Is this something you'd like to come back to, in order to update it slightly and have it merged? Thanks! |
Part 1 of a specutils tutorial series
How to Load, Plot, and Smooth an Optical Spectrum from SDSS
Ready for review. This is in response to Issue #440