Better migration simbad

[ManonMarchand]

This PR fixes the two points raised by #3185

On the deprecated notation flux(XXX)

There was a bug when adding a list of fluxes with the deprecated API:

from astroquery.simbad import Simbad
simbad = Simbad()
simbad.add_votable_fields("flux(U)", "flux(J)")

would error instead of just warn. This was due to a nasty modification of a list in the loop that was iterating over it (introduced in #3052).

On votable fields

I figured that I based my deprecations / changes of names on the old SIMBAD API docs, and not on astroquery docs. They did not have exactly the same fields. This is the second commit of this PR. It:

• adds support for dec_prec, diameter, otype(3), otype(s), pm, ra_prec (all from deprecated API, they now raise a warning stating the new name instead of failing)
• fixes otype(V) and otype(S) that had a case issue (but are deprecated)
• raises more meaningful errors on the following keywords that cannot be ported to the new API td1, sp_nature, pos, posa, typed_id, ubv, uvby1, uvby
• add ra(d) and dec(d) as aliases for ra and dec

It would be very nice if these two changes could be back-ported to astroquery v0.4.8 as these only affect the deprecated API, and thus people migrating from 0.4.7.

[pep8speaks]

Hello @ManonMarchand! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-21 17:36:10 UTC

[bsipocz]

Thanks Manon! I won't backport but can do a new tagged release, so people can get all the fixes we did since the release.

[ManonMarchand]

That would be nice, I hope there is nothing else remaining

[ManonMarchand]

(I also got feedback from the astronomer in charge of SIMBAD's scientific content that query_hierarchy should be detailed per default. This is way less critical... But do you know when this new tagged release would be?)

[bsipocz]

I'll try to do one towards the end of the week once a few more quick bugfixes are in, too.

[bsipocz]

Looks good, thank you. One minor comment on the deprecation message.

[ManonMarchand]

Switching it to draft. I'll port all our internal tutorials from the point of view of someone who has no idea about the refactor to see if I find more pain points. This way I might catch some other deprecation messages that are unclear or buggy.
I'm doing this today.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b005fc9). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3186   +/-   ##
=======================================
  Coverage        ?   67.42%           
=======================================
  Files           ?      229           
  Lines           ?    18612           
  Branches        ?        0           
=======================================
  Hits            ?    12550           
  Misses          ?     6062           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ManonMarchand]

I added ra(d) and dec(d) in the renamed arguments so that they raise a DeprecationWarning instead of an Error (squashed in the former commits)

One thing that appeared in the investigation is the new case-sensitivity of query_catalog. It's written in the docstring of the method, but I forgot to mention it in the changelog. Can I edit the 0.4.8 section of the changelog to add it? Or should it be in the 0.4.9 section even if the change happened before?