Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge mask in Combiner.sigma_clipping, instead of overwriting it #850

Closed
wants to merge 3 commits into from
Closed

Merge mask in Combiner.sigma_clipping, instead of overwriting it #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d194f0d
merge mask instead of overwriting
kbwestfall Oct 22, 2024
7a7be75
add author
kbwestfall Oct 22, 2024
353c2ab
CHANGES
kbwestfall Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ Alphabetical list of code contributors
* Josh Walawender (@joshwalawender)
* Nathan Walker (@walkerna22)
* Benjamin Weiner (@bjweiner)
* Kyle B. Westfall (@kbwestfall)
* Jiyong Youn (@hletrd)

Additional contributors
Expand Down
4 changes: 3 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
2.4.1 (unreleased)
2.4.3 (unreleased)
------------------

New Features
Expand All @@ -7,6 +7,8 @@ New Features
Other Changes and Additions
^^^^^^^^^^^^^^^^^^^^^^^^^^^

- ``Combiner.sigma_clipping`` no longer overwrites the existing mask.

2.4.2 (2024-05-03)
------------------

Expand Down
2 changes: 1 addition & 1 deletion ccdproc/combiner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def sigma_clipping(
# Remove in 3.0
_ = kwd.pop("use_astropy", True)

self.data_arr.mask = sigma_clip(
self.data_arr.mask |= sigma_clip(
self.data_arr.data,
sigma_lower=low_thresh,
sigma_upper=high_thresh,
Expand Down