WIP: Allow a 2D threshold in StarFinder classes #1293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @rainerschoedel noted in #1284 a non-uniform threshold over an image would be nice to have. As find_peaks already supports this, it appeared to be relatively straightforward to implement in the
StarFinder
classes.I won't have much time the next few weeks, so if is this PR is something that you would consider merging let me know and I'll clean it up when I find the time.
What needs a bit of work
What I'm not sure about
exclude_border
?