Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow a 2D threshold in StarFinder classes #1293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krachyon
Copy link
Contributor

As @rainerschoedel noted in #1284 a non-uniform threshold over an image would be nice to have. As find_peaks already supports this, it appeared to be relatively straightforward to implement in the StarFinder classes.

I won't have much time the next few weeks, so if is this PR is something that you would consider merging let me know and I'll clean it up when I find the time.

What needs a bit of work

  • Reading the table in tests with 2D threshold is really hacky.
  • A test with an image with variable background to see it in action
  • A bit of QOL: Verify the shapes of threshold and data as soon as possible and report understandable error

What I'm not sure about

  • Is padding the threshold with zeros the right thing to do? Or should it just be restricted to be used with exclude_border?

@pep8speaks
Copy link

Hello @krachyon! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 415:5: E301 expected 1 blank line, found 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants