Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped CI dependencies #279

Merged
merged 11 commits into from
Dec 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions .github/workflows/cibuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@ jobs:
tests:
needs: egginfo
runs-on: ubuntu-latest
name: ${{ matrix.python-version }} with ${{ matrix.astropy-version }}
name: ${{ matrix.python-version }}
strategy:
fail-fast: true
matrix:
python-version: [3.7, 3.8, 3.9]
astropy-version: [latest ,astropy40, astropy41]
python-version: ["3.7", "3.8", "3.9", "3.10"]
steps:
- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -44,7 +43,7 @@ jobs:
# remove "." from matrix.python-version to get the defaults tox python versions
tox_python_target=$(echo py${{matrix.python-version}} | sed 's/\.//')
echo "Tox python target: " $tox_python_target
tox -e $tox_python_target-${{ matrix.astropy-version }}
tox -e $tox_python_target-test


mac_windows:
Expand Down Expand Up @@ -91,9 +90,23 @@ jobs:
with:
file: ./coverage.xml

astropydev:
devastropy:
# TODO: this job should be allowed to fail except that the functionality
# is not available in actions yet.
runs-on: ubuntu-latest
needs: tests
steps:
- uses: actions/checkout@v2
- name: Set up Python 3.10
uses: actions/setup-python@v2
with:
python-version: "3.10"
- name: Install tox
run: python -m pip install --upgrade tox
- name: Run tests against devastropy
run: tox -e py310-test-devastropy

oldestastropy:
runs-on: ubuntu-latest
needs: tests
steps:
Expand All @@ -104,8 +117,8 @@ jobs:
python-version: 3.8
- name: Install tox
run: python -m pip install --upgrade tox
- name: Run tests against astropy dev
run: tox -e py38-astropydev
- name: Run tests against oldestastropy
run: tox -e py38-test-oldestastropy

#publish:
#needs: coverage
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ license = BSD
url = https://github.com/astropy/pyvo
edit_on_github = False
github_project = astropy/pyvo
install_requires = astropy requests
install_requires = astropy>=4.0 requests
# version should be PEP440 compatible (http://www.python.org/dev/peps/pep-0440)
version = 1.2.dev

Expand Down
15 changes: 9 additions & 6 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
[tox]
# Please note that not all the combinations below are guaranteed to work
# as oldestastropy and devastropy might not support the full python range
# listed here
envlist =
py{37,38,39}-{latest,astropy40,astropy41}
py38-astropydev
py{37,38,39,310}-test{,-oldestastropy, -devastropy}
egg_info
cov
linkcheck
Expand All @@ -20,12 +22,13 @@ commands =

description =
run tests
astropy40: with astropy 4.0.*
astropy41: with astropy 4.1.*
latest: with astropy latest
oldestdeps: with astropy 4.0.*
devastropy: with astropy latest

deps =
#-rpip-requirements
devastropy: git+https://github.com/astropy/astropy.git#egg=astropy
oldestdeps: astropy==4.0
astropy
requests
Comment on lines +31 to 32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be picked up from the setup file, don't need to list them out in tox (unless of course you want to set a version number for them), but you may need to add an [options] section, too (I'm not sure whether dependencies would be properly picked up from [metadata])

mimeparse
pytest-astropy
Expand Down