DEP: Deprecate vodataservice Table #484
Conversation
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 80.00% 80.01% +0.01%
==========================================
Files 52 52
Lines 6035 6039 +4
==========================================
+ Hits 4828 4832 +4
Misses 1207 1207
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| query result from get_tables. | ||
| """ | ||
| res = vodataservice.Table() | ||
| res = vodataservice.VODataServiceTable() |
There was a problem hiding this comment.
Hm. I wonder why the coverage machinery considers this uncovered. I've just checked: all of test_regtap.TestGetTables fail if you get this wrong. I won't debug codecov, but I consider this warning a false positive.
There was a problem hiding this comment.
codecov is sometimes behaves weird. My usual approach for it is not to take it too seriously, but if it indicates something substantial, look into the details manually.
Thank you for doing it for this case.
|
The RTD failing status has already been fixed in |
to close #477
I haven't touched the other classes in the module, for consistency it may make some sense to rename all with the prefix
VODataService, but unlike forTable, it would be purely cosmetical for them.