Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The regtap Ivoid constraint can now take multiple ivoids. #517

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

msdemlei
Copy link
Contributor

As usual in the pyvo Regtap API, these will then be matched in a disjunction.

As usual in the pyvo Regtap API, these will then be matched in a
disjunction.
@msdemlei msdemlei force-pushed the support-multiple-ivoids branch from 26610f3 to 1146693 Compare January 30, 2024 13:50
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3c9d85) 80.32% compared to head (1146693) 80.33%.

❗ Current head 1146693 differs from pull request most recent head 902a303. Consider uploading reports for the commit 902a303 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   80.32%   80.33%           
=======================================
  Files          52       52           
  Lines        6176     6177    +1     
=======================================
+ Hits         4961     4962    +1     
  Misses       1215     1215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz added this to the v1.6 milestone Jan 30, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @msdemlei! I'll push a commit that fixes pep8 and will merge this.

@bsipocz bsipocz merged commit 3a24ac2 into astropy:main Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants