Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of Freetext constraint #577

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

ManonMarchand
Copy link
Member

@ManonMarchand ManonMarchand commented Jul 12, 2024

Freetext does not expect a tuple of strings, but multiple string arguments, I know it's nitpicky but I'll teach the use of it soon and I'd expect this to be a bit confusing for the students if we don't change.

Edit: there were other occurences

@ManonMarchand ManonMarchand force-pushed the docs-edit-freetext-constraint branch from 8c7432a to b4def66 Compare July 12, 2024 07:46
Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valuable clarification -- thanks!

@msdemlei msdemlei merged commit c868716 into main Jul 12, 2024
12 checks passed
@msdemlei msdemlei deleted the docs-edit-freetext-constraint branch July 12, 2024 08:36
@bsipocz bsipocz added this to the v1.5.3 milestone Jul 12, 2024
@bsipocz
Copy link
Member

bsipocz commented Jul 12, 2024

minor comment: @ManonMarchand - please use branches for PRs in your fork rather than in the main repo.

@ManonMarchand
Copy link
Member Author

Sure, sorry!

bsipocz pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants