Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: examples have changed upstream, change index in docs #585

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 13, 2024

The index was quite deterministic so far, so let's change it for now, and only skip the output checking when/if it keeps failing again.

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dang, that's my service and I broke this. I'll leave a note in the source that produces this to keep examples[1] constant unless there is a really overriding reason to change it.

Thanks for cleaning up behind me!

@msdemlei msdemlei merged commit c1f6903 into astropy:main Aug 14, 2024
10 checks passed
@bsipocz bsipocz deleted the DOC_tap_example branch August 14, 2024 15:18
@bsipocz
Copy link
Member Author

bsipocz commented Aug 14, 2024

Thanks. No worries, it's ok to change it, I assume it's not something to happen often anyway. I was just not sure if the change was due as it's a result of an unordered query result or due to upstream changes.

bsipocz pushed a commit that referenced this pull request Oct 14, 2024
DOC: examples have changed upstream, change index in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants