Close FITS files after loading #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 91.75% 91.77% +0.01%
==========================================
Files 24 24
Lines 716 717 +1
==========================================
+ Hits 657 658 +1
Misses 59 59
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
astrofrog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a comment pointing out that when FITS file names are passed for the input data, the file is opened but never closed. Changing that looked like a quick fix, and should be safe---after the file is opened,
parse_input_datacalls itself a few times before eventually extracting the.dataand.headerattributes of the selected HDU and returning those, so the HDUL object never leavesparse_input_data. (Not sure if the garbage collector would have eventually closed everything anyway.)While checking that this was covered by existing tests, I saw that the
parse_input_datatests were checking the data array that gets returned but not the corresponding WCS, so I augmented those tests to check both.(The CI failure appears to be pre-existing)