Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird quotation marks from Black auto-formatting #331

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

svank
Copy link
Contributor

@svank svank commented Dec 30, 2022

Noticed another little thing---a commit a few months ago auto-reformatted the code with Black. Black must have been imposing a new, larger maximum line length and it reflowed some strings that had been broken across multiple lines, but it left extra quotation marks in place while it did that

(CI failure appears to be pre-existing)

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #331 (5f47be5) into main (aa23eb1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files          24       24           
  Lines         716      716           
=======================================
  Hits          657      657           
  Misses         59       59           
Impacted Files Coverage Δ
reproject/healpix/high_level.py 93.75% <ø> (ø)
reproject/mosaicking/coadd.py 92.42% <ø> (ø)
reproject/utils.py 87.75% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astrofrog astrofrog merged commit d39de23 into astropy:main Dec 31, 2022
@svank svank deleted the fix-weird-quotes branch June 23, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants