Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests on Python 3.11 #401

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Add tests on Python 3.11 #401

merged 3 commits into from
Oct 18, 2023

Conversation

dstansby
Copy link
Contributor

Pulled out of #399 for easier review.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #401 (9d0ea84) into main (17baf04) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          25       25           
  Lines         891      891           
=======================================
  Hits          834      834           
  Misses         57       57           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dstansby
Copy link
Contributor Author

I harrowed the test failures down to a change in shapely version from 2.0.1 > 2.0.2. I haven't checked the changelog (https://github.com/shapely/shapely/releases/tag/2.0.2) in detail to work out why stuff has changed, but I've fixed the tests here.

@Cadair Cadair requested a review from astrofrog October 18, 2023 16:13
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@astrofrog astrofrog merged commit 7e1dc81 into astropy:main Oct 18, 2023
27 checks passed
@dstansby dstansby deleted the py311-tests branch October 18, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants