-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-threaded reprojection when using Astropy WCS #434
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 93.60% 93.63% +0.02%
==========================================
Files 25 25
Lines 892 895 +3
==========================================
+ Hits 835 838 +3
Misses 57 57 ☔ View full report in Codecov by Sentry. |
…bject for each chunk
Should the deep copy only be done for the multi-threading case, or is the copy so fast + low-memory that it does not matter |
@manodeep - the deep copy only takes ~10µs for a typical WCS, so it will be buried in the noise |
The fix here is a workaround but it is acceptable enough to just go ahead and merge, as even though it does not fix astropy upstream, it should basically make multi-threading usable here. |
…elated issue when this is True.
c9e5d8e
to
2f69628
Compare
Let's get this fix in 🚀 |
To run just the relevant test:
This currently shows three test failures:
To run just one of the parameter combinations of the test, one can do e.g.: