Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readonly arrays in adaptive #452

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

svank
Copy link
Contributor

@svank svank commented Jun 19, 2024

@astrofrog This is what I found for readonly arrays in Cython: cython/cython#1869

Just need to add const to the types of the input arrays

Closes #449 ?

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (0860f9f) to head (e9620c8).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   91.27%   91.52%   +0.25%     
==========================================
  Files          25       25              
  Lines        1066     1027      -39     
==========================================
- Hits          973      940      -33     
+ Misses         93       87       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svank
Copy link
Contributor Author

svank commented Jun 19, 2024

Not sure about the test failures---I think they're unrelated?

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the failures are unrelated - thanks!

@astrofrog astrofrog merged commit f684098 into astropy:main Jun 27, 2024
12 of 16 checks passed
@astrofrog astrofrog added the bug label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_coordinates in adaptive reprojection does not accept read-only arrays
2 participants