Correct default mask for array images in HorneExtract

[ojustino]

When HorneExtract/OptimalExtract is given a numpy array as an image and no mask, it tries to create its own mask using np.ma.masked_invalid(image). They are currently written as if that object itself is the mask, when it's actually in that object's mask attribute. This pull request makes the switch.

[kecnry]

Fixes the case that I was seeing! Does this need a changelog entry as a bugfix?

[ojustino]

Good call, @kecnry; I went ahead and created a new section in CHANGES.rst.

[codecov]

Codecov Report

Merging #118 (e295641) into main (37d4502) will increase coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   69.43%   70.09%   +0.66%     
==========================================
  Files           9        9              
  Lines         602      602              
==========================================
+ Hits          418      422       +4     
+ Misses        184      180       -4     

Impacted Files	Coverage Δ
specreduce/extract.py	89.47% <100.00%> (+3.00%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tepickering]

looks good and another nice catch. codecov says and i agree it'd be worth adding a test case to cover this.

[ojustino]

The coverage needed here likely clashes with #117 since image is one of the parameters whose location is changed there. That one is close to complete, though we may need to discuss how to handle a merge given that it breaks the API.

[kecnry]

@ojustino - if you add a test here that covers the case that used to fail, I can update it if needed when rebasing (since I'm guessing this will get merged before that one).

[ojustino]

OK, the tests are in.