Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with units #221

Merged
merged 3 commits into from
Jun 20, 2024
Merged

fix issue with units #221

merged 3 commits into from
Jun 20, 2024

Conversation

cshanahan1
Copy link
Contributor

@cshanahan1 cshanahan1 commented Jun 17, 2024

fixes a few things

  • background one sided / two sided not properly assigning units to data when new image is passed in.
  • fixed check for quantity vs array in parse data
  • add change log section for 1.4.1

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (388adb0) to head (6b82bb5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          13       13           
  Lines        1137     1137           
=======================================
  Hits          948      948           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tepickering tepickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. looks good and ready for version bump.

@cshanahan1 cshanahan1 merged commit 5620d7b into astropy:main Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants