Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shader code and add webgl flush #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix shader code and add webgl flush #17

wants to merge 1 commit into from

Conversation

maeneak
Copy link

@maeneak maeneak commented Jun 4, 2019

Code changes to fix floating point bug from #12 and reduce particle flickering on mobile browsers. I've also added a small update to particle.js for 2 random DOMMatrix definitions not using the window object which were blocking the use of polyfills for browsers that dont support the Geometry Interfaces spec (edge desktop etc.). The use of DOMMatrixReadOnly in util.js also blocks this and replacing it with DOMMatrix tests fine, is there any benifit in using DOMMatrixReadOnly?

@gampleman
Copy link
Contributor

is there any benifit in using DOMMatrixReadOnly

Not really, just being paranoid about mutating stuff that shouldn't be.

@maeneak
Copy link
Author

maeneak commented Jun 4, 2019

You may be able to find a more elegant way to do the gl.flush(). Most of my research came from pixijs/pixijs#3432
I didn't do any testing on whether it was required in both render and prerender calls.

@j08lue
Copy link

j08lue commented Aug 26, 2020

As far as I can see, these are relevant and localized changes. Probably not tested in a while, but can this perhaps just be merged? The original branch is gone, it seems, and it would be too bad to lose this fix. We can give it a spin and report back, if this gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants