Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite responsive page #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rewrite responsive page #6

wants to merge 2 commits into from

Conversation

justrinoo
Copy link

I changed the navbar dipage index.html section
I changed the layout on the index.html page with semantic UI
I added a jquery animation for the sidebar on the left

@gridhead
Copy link
Member

Thank you for your contributions to the repository @rinolvy.

Please do comment under the issue that you are trying to resolve here for assignment (if it has not been assigned to anyone yet). Once, it is assigned to you - feel free to reach out so that I can begin with reviewing this PR.

@justrinoo
Copy link
Author

I have added a responsive mobile device so that the user can see comfortably, and I have changed the page content section with the card from the semantic UI

@gridhead gridhead self-requested a review September 25, 2020 08:09
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I appreciate your contributions - I do remark that you should have assigned yourself the issue first by commenting under the issue and then, you should have started the work on it. I would now suggest you to make conversation with the current assignee of #5 under the issue to see if they are okay with relinquishing their assignment because your work is done.

Once they leave the assignment, I would assign that to you and then, begin with reviewing your pull request. Not before that. Happy hacking! 😄

@gridhead gridhead added the invalid This doesn't seem right label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants