Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building the native plugins by CircleCI #265

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

stakemura
Copy link
Contributor

@stakemura stakemura commented Nov 29, 2022

Hi, I'm ready to send PR to build the native plugins by CircleCI.
As the following result showed, CircleCI can build the all (macOS, Windows, Linux, iOS, Android) TFLite 2.10.0 native plugins successfully on free account.

https://app.circleci.com/pipelines/github/stakemura/tf-lite-unity-sample/53/workflows/9995ca29-237f-4276-ad68-2dacd6152387

As for the gpu-api-delegate, please comment out the following patch.

# For gpu-api-delegate branch
# sed -i -e 's/libtensorflowlite_gpu_delegate.so/libtensorflowlite_gpu_api_delegate.so/' ../tensorflow/tensorflow/lite/delegates/gpu/BUILD 
# sed -i -e 's/\":delegate\"/\"\/\/tensorflow\/lite\/delegates\/gpu\/cl:gpu_api_delegate\"/' ../tensorflow/tensorflow/lite/delegates/gpu/BUILD

Also I need some modifications about build_tflite.py to support continuous builds.
For example, I made it possible to return the error code when bazel failed to build.

    ret = subprocess.call(args, cwd=TENSORFLOW_PATH, shell=is_shell)
    if ret != 0:
        sys.exit(ret)

I would appreciate it if you could consider the merge.

@asus4
Copy link
Owner

asus4 commented Nov 30, 2022

@stakemura Thank you for the great PR. Code changes look ok to me. Let me merge it and see it on my CircleCI.

@asus4 asus4 merged commit 9bdb7d1 into asus4:master Nov 30, 2022
@stakemura stakemura deleted the v2.10.0-circleci branch November 30, 2022 14:55
AhmadMendung pushed a commit to AhmadMendung/tf-lite-unity-sample that referenced this pull request Jun 27, 2024
Add support for building the native plugins by CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants