Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some dependency issues due to some pip updates #325

Merged
merged 7 commits into from
Dec 6, 2020

Conversation

hunterhector
Copy link
Member

@hunterhector hunterhector commented Dec 4, 2020

This PR tries to resolve the recent dependency issues.

Description of changes

Updates a few package dependencies, such as bumping AllenNLP to 1.1.0, and relaxing the requirements on pytorch.

Currently installing the bleeding-edge pip to avoid the huge list of downloads in pip 20.3 (pypa/pip#9215)

Possible influences of this PR.

Not sure whether these dependency changes will cause problems in the other part of the code base. There should not be significant problems if we pass the test.

Test Conducted

Describe what test cases are included for the PR.

hector.liu added 6 commits December 4, 2020 01:30
1. Remove stubs and use Pytorch defaults
2. Update pylint to 2.6.0, fix a few more warnings raised by that.
@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #325 (ec45dda) into master (66462e7) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files         154      154           
  Lines        9919     9919           
=======================================
  Hits         7917     7917           
  Misses       2002     2002           
Impacted Files Coverage Δ
forte/data/ontology/core.py 78.05% <0.00%> (ø)
forte/data/ontology/utils.py 65.15% <ø> (ø)
forte/models/srl/model.py 14.63% <0.00%> (ø)
forte/processors/base/batch_processor.py 85.34% <ø> (ø)
forte/processors/vocabulary_processor.py 28.57% <0.00%> (ø)
forte/data/ontology/ontology_code_generator.py 90.23% <50.00%> (ø)
forte/data/batchers.py 77.31% <100.00%> (ø)
forte/data/ontology/code_generation_objects.py 94.84% <100.00%> (ø)
forte/data/ontology/top.py 85.71% <100.00%> (ø)
forte/models/srl/model_utils.py 24.88% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66462e7...ec45dda. Read the comment docs.

@hunterhector hunterhector merged commit 8227087 into asyml:master Dec 6, 2020
@hunterhector hunterhector deleted the version branch December 6, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant