-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse user specified ontology file #692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 80.35% 80.40% +0.05%
==========================================
Files 253 253
Lines 19315 19358 +43
==========================================
+ Hits 15520 15565 +45
+ Misses 3795 3793 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to reuse the ontology code generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In additional to the comments, there are a few more general steps missing:
- We always need to associate a PR with an issue for tracking purposes.
- Need to resolve conflicts.
d5806e0
to
35596ab
Compare
let's pass the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR let's focus on making the test case covering what we want.
This PR handles the parameter onto_file_path in DataStore's init method.
Description of changes
If onto_file_path is not None, build tyoe_attribute dictionary based on the provided ontology file.
Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
test_check_onto_file in data store test.