Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable codecov/patch #261

Closed
gpengzhi opened this issue Nov 30, 2019 · 1 comment · Fixed by #265
Closed

Disable codecov/patch #261

gpengzhi opened this issue Nov 30, 2019 · 1 comment · Fixed by #265
Labels
enhancement New feature or request

Comments

@gpengzhi
Copy link
Collaborator

Mentioned in #255 "I tried to disable codecov/patch because some of our tests (pre-trained tests) are done locally. codecov/patch is also reported to be not very reliable. Some other projects have met such issues (argoproj/argo-cd#1926). I think codecov/project is good enough to check the code quality for now. I tried many ways to disable codecov/patch but failed. It seems that someone also met a similar problem (https://community.codecov.io/t/cannot-disable-codecov-patch-check/682/4). Do you think it is reasonable to merge PRs regardless of the status of codecov/patch?"
@gpengzhi gpengzhi added the enhancement New feature or request label Nov 30, 2019
@gpengzhi
Copy link
Collaborator Author

gpengzhi commented Dec 2, 2019

https://community.codecov.io/t/cannot-disable-codecov-patch-check/682/8

@gpengzhi gpengzhi mentioned this issue Dec 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable codecov/patch
1 participant
@gpengzhi