Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable codecov/patch #1926

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Disable codecov/patch #1926

merged 1 commit into from
Jul 11, 2019

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jul 11, 2019

Looks like codecov/patch is not reliable and keep failiing. I've noticed some other projects having the same issue: mozilla-mobile/firefox-tv#778, kata-containers/tests#508

I think it is easier to disable it and keep project check only

@alexmt alexmt requested review from alexec and jessesuen July 11, 2019 23:26
@alexec alexec merged commit e93b0a0 into argoproj:master Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #1926 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
+ Coverage   35.98%   36.05%   +0.07%     
==========================================
  Files          89       89              
  Lines       12768    12768              
==========================================
+ Hits         4594     4603       +9     
+ Misses       7545     7532      -13     
- Partials      629      633       +4
Impacted Files Coverage Δ
controller/appcontroller.go 41.88% <0%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377fa55...676079e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #1926 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
+ Coverage   35.98%   36.05%   +0.07%     
==========================================
  Files          89       89              
  Lines       12768    12768              
==========================================
+ Hits         4594     4603       +9     
+ Misses       7545     7532      -13     
- Partials      629      633       +4
Impacted Files Coverage Δ
controller/appcontroller.go 41.88% <0%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377fa55...676079e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants