Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in RoBERTa #241

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Bugfix in RoBERTa #241

merged 2 commits into from
Nov 2, 2019

Conversation

gpengzhi
Copy link
Collaborator

@gpengzhi gpengzhi commented Nov 1, 2019

"10.xxxxx" => "10" and "xxxxx"

@huzecong
Copy link
Collaborator

huzecong commented Nov 1, 2019

Why was it not caught by tests before? How did you find this?

@gpengzhi
Copy link
Collaborator Author

gpengzhi commented Nov 1, 2019 •
edited
Loading

Why was it not caught by tests before? How did you find this?

No error was triggered before because layer_name is not in attention_tensor_map. Maybe it should raise a NameError if the layer with this name is not found. I found it when I added SpanBERT.

@gpengzhi gpengzhi merged commit 4fee264 into asyml:master Nov 2, 2019
@gpengzhi gpengzhi deleted the roberta-fix branch February 4, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhitingHu ZhitingHu ZhitingHu approved these changes

@huzecong huzecong Awaiting requested review from huzecong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpengzhi @huzecong @ZhitingHu