Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs issues #290

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Fix docs issues #290

merged 4 commits into from
Feb 5, 2020

Conversation

gpengzhi
Copy link
Collaborator

@gpengzhi gpengzhi commented Feb 5, 2020

Fix CI error in #260

ZhitingHu and others added 3 commits November 28, 2019 21:57
- expose `DecoderBase` in doc
- delete unnecessary code in examples/gpt-2
- update doc of TransformerDecoder and RNNDecoderBase
@gpengzhi gpengzhi mentioned this pull request Feb 5, 2020
@gpengzhi gpengzhi changed the title Zhiting hu/master Fix docs issues Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #290 into master will increase coverage by 0.39%.
The diff coverage is 70.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   82.25%   82.64%   +0.39%     
==========================================
  Files         206      207       +1     
  Lines       15928    16005      +77     
==========================================
+ Hits        13102    13228     +126     
+ Misses       2826     2777      -49
Impacted Files Coverage Δ
texar/torch/modules/encoders/bert_encoder_test.py 54.54% <ø> (ø) ⬆️
...xar/torch/modules/decoders/decoder_helpers_test.py 95.65% <ø> (ø) ⬆️
...xar/torch/modules/encoders/roberta_encoder_test.py 54.54% <ø> (ø) ⬆️
texar/torch/losses/entropy_test.py 97.87% <ø> (ø) ⬆️
texar/torch/losses/adv_losses_test.py 94.11% <ø> (ø) ⬆️
texar/torch/modules/encoders/xlnet_encoder_test.py 52.38% <ø> (ø) ⬆️
...torch/modules/classifiers/conv_classifiers_test.py 96.55% <ø> (ø) ⬆️
texar/torch/modules/embedders/embedder_base.py 94.11% <ø> (ø) ⬆️
texar/torch/losses/pg_losses_test.py 98.03% <ø> (ø) ⬆️
...orch/modules/decoders/transformer_decoders_test.py 98.76% <ø> (ø) ⬆️
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4234ac5...aaacee2. Read the comment docs.

@gpengzhi gpengzhi merged commit b2daf1d into asyml:master Feb 5, 2020
@gpengzhi gpengzhi deleted the ZhitingHu/master branch February 5, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants