Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inject InvalidArgument class when not needed #1608

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Do not inject InvalidArgument class when not needed #1608

merged 1 commit into from
Nov 23, 2023

Conversation

jderusse
Copy link
Member

We currently always inject the class, then rely on PhpCsFixer to remove it if unused.

However, when a comment contains the word InvalidArgument, then PhpCsFixer keeps it.

@jderusse jderusse force-pushed the fix-invalidargument branch 2 times, most recently from d8c46c6 to 79617eb Compare November 23, 2023 12:28
@jderusse jderusse force-pushed the fix-invalidargument branch from 79617eb to 4a315f2 Compare November 23, 2023 12:31
@jderusse
Copy link
Member Author

Failing test about the changelog not being updated is expected.

GrahamCampbell
GrahamCampbell approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

@jderusse jderusse merged commit 1cf60ae into async-aws:master Nov 23, 2023
13 of 15 checks passed
@jderusse jderusse deleted the fix-invalidargument branch November 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @GrahamCampbell