Skip to content

Conversation

shadowhand
Copy link

No description provided.

@shadowhand
Copy link
Author

Obviously there are some things that need to be fixed in the tests, but I don't know where to start or how to properly run the tests locally. When I try to run make test it does a lot of stuff and then terminates with:

PHP Fatal error:  Declaration of PHPUnit\Framework\TestSuite::run(): void must be compatible with PHPUnit\Framework\Test::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult in /Users/woodygilk/Code/async-aws/aws/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 332

Fatal error: Declaration of PHPUnit\Framework\TestSuite::run(): void must be compatible with PHPUnit\Framework\Test::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult in /Users/woodygilk/Code/async-aws/aws/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 332
make: *** [test] Error 255

@stof
Copy link
Member

stof commented Oct 16, 2025

how are you running PHPUnit ? Have you installed latest dependencies in your local setup ? And is this based on an uptodate state of the master branch ?

@shadowhand
Copy link
Author

@stof make test. Yes, I have run composer install. Yes, this is from master branch.

@stof
Copy link
Member

stof commented Oct 17, 2025

In case you have your local setup since quite some times, run composer update instead of composer install (composer install would reinstall what you have in your local composer.lock file from the last time you updated vendors)

@stof stof mentioned this pull request Oct 17, 2025
@stof
Copy link
Member

stof commented Oct 17, 2025

I found the issue with our local setup and I submitted a PR to fix it.

@stof
Copy link
Member

stof commented Oct 17, 2025

@shadowhand the issue with make test is now fixed in the latest master branch.

$input = new PutPublicAccessBlockRequest([
'Bucket' => 'change me',
'ContentMD5' => 'change me',
'ChecksumAlgorithm' => 'change me',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all those change me values should be updated to be valid values for those field in the test (as hinted by the string content in the generated test skeleton)

PUT / HTTP/1.0
Content-Type: application/xml
<change>it</change>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this <change>it</change> should also be replaced by the actual expected content.

{
public function testRequest(): void
{
self::fail('Not implemented');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the test is properly implemented, this line should be removed.

$input = new PutPublicAccessBlockRequest([
'Bucket' => 'change me',
'ContentMD5' => 'change me',
'ChecksumAlgorithm' => 'change me',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all those change me values should be updated to be valid values for those field in the test (as hinted by the string content in the generated test skeleton)

"ext-hash": "*",
"ext-simplexml": "*",
"async-aws/core": "^1.22"
"async-aws/core": "^1.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is wrong. This requirement is managed by the code generator. Please make sure that you ran the latest version of the code generator (rather than running an old version and then rebasing the generated code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants