-
-
Notifications
You must be signed in to change notification settings - Fork 144
Support S3::PutPublicAccessBlock #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Obviously there are some things that need to be fixed in the tests, but I don't know where to start or how to properly run the tests locally. When I try to run
|
how are you running PHPUnit ? Have you installed latest dependencies in your local setup ? And is this based on an uptodate state of the master branch ? |
@stof |
In case you have your local setup since quite some times, run |
I found the issue with our local setup and I submitted a PR to fix it. |
@shadowhand the issue with |
$input = new PutPublicAccessBlockRequest([ | ||
'Bucket' => 'change me', | ||
'ContentMD5' => 'change me', | ||
'ChecksumAlgorithm' => 'change me', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all those change me
values should be updated to be valid values for those field in the test (as hinted by the string content in the generated test skeleton)
PUT / HTTP/1.0 | ||
Content-Type: application/xml | ||
<change>it</change> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this <change>it</change>
should also be replaced by the actual expected content.
{ | ||
public function testRequest(): void | ||
{ | ||
self::fail('Not implemented'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the test is properly implemented, this line should be removed.
$input = new PutPublicAccessBlockRequest([ | ||
'Bucket' => 'change me', | ||
'ContentMD5' => 'change me', | ||
'ChecksumAlgorithm' => 'change me', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all those change me
values should be updated to be valid values for those field in the test (as hinted by the string content in the generated test skeleton)
"ext-hash": "*", | ||
"ext-simplexml": "*", | ||
"async-aws/core": "^1.22" | ||
"async-aws/core": "^1.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is wrong. This requirement is managed by the code generator. Please make sure that you ran the latest version of the code generator (rather than running an old version and then rebasing the generated code)
No description provided.