Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · a550d51 · a550d51
1 parent e99e482
commit a550d51
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Changed
 
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
 - AWS enhancement: Documentation updates.
 
 ## 2.2.2

diff --git a/src/Input/CreateSecretRequest.php b/src/Input/CreateSecretRequest.php
@@ -261,6 +261,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'secretsmanager.CreateSecret',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/DeleteSecretRequest.php b/src/Input/DeleteSecretRequest.php
@@ -106,6 +106,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'secretsmanager.DeleteSecret',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/GetSecretValueRequest.php b/src/Input/GetSecretValueRequest.php
@@ -100,6 +100,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'secretsmanager.GetSecretValue',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/ListSecretsRequest.php b/src/Input/ListSecretsRequest.php
@@ -126,6 +126,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'secretsmanager.ListSecrets',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/PutSecretValueRequest.php b/src/Input/PutSecretValueRequest.php
@@ -166,6 +166,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'secretsmanager.PutSecretValue',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/UpdateSecretRequest.php b/src/Input/UpdateSecretRequest.php
@@ -176,6 +176,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'secretsmanager.UpdateSecret',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/tests/Unit/Input/CreateSecretRequestTest.php b/tests/Unit/Input/CreateSecretRequestTest.php
@@ -33,6 +33,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: secretsmanager.CreateSecret
+            Accept: application/json
 
             {
                 "ClientRequestToken": "EXAMPLE1-90ab-cdef-fedc-ba987SECRET1",

diff --git a/tests/Unit/Input/DeleteSecretRequestTest.php b/tests/Unit/Input/DeleteSecretRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: secretsmanager.DeleteSecret
+            Accept: application/json
 
             {
                 "RecoveryWindowInDays": 7,

diff --git a/tests/Unit/Input/GetSecretValueRequestTest.php b/tests/Unit/Input/GetSecretValueRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: secretsmanager.GetSecretValue
+            Accept: application/json
 
             {
                 "SecretId": "MyTestDatabaseSecret",

diff --git a/tests/Unit/Input/ListSecretsRequestTest.php b/tests/Unit/Input/ListSecretsRequestTest.php
@@ -27,6 +27,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: secretsmanager.ListSecrets
+            Accept: application/json
 
             {
                 "Filters": [

diff --git a/tests/Unit/Input/PutSecretValueRequestTest.php b/tests/Unit/Input/PutSecretValueRequestTest.php
@@ -21,6 +21,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: secretsmanager.PutSecretValue
+            Accept: application/json
 
             {
                 "ClientRequestToken": "EXAMPLE2-90ab-cdef-fedc-ba987EXAMPLE",

diff --git a/tests/Unit/Input/UpdateSecretRequestTest.php b/tests/Unit/Input/UpdateSecretRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: secretsmanager.UpdateSecret
+            Accept: application/json
 
             {
                 "ClientRequestToken": "EXAMPLE1-90ab-cdef-fedc-ba987EXAMPLE",