Skip to content

Commit

Permalink
Upgrade localstack (#1604)
Browse files Browse the repository at this point in the history
* Upgrade localstack

* Fix the dynamodb integration tests

The new localstack version emulates AWS better, returning a consumed
capacity only when the request asks for it.

* Update the Sts integration test for the new localstack return values

* Update the route53 expectation for the listing endpoint

In the new localstack version, creating a zone automatically creates the
NS and SOA records for that zone, emulating what actually happens on
AWS.

* Switch to 3.0.0

* Skip bad test for now

---------

Co-authored-by: Christophe Coevoet <stof@notk.org>
  • Loading branch information
GrahamCampbell and stof authored Nov 22, 2023
1 parent 1831e59 commit df33cfb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ initialize: start-docker
start-docker:
docker start async_aws_localstack && exit 0 || \
docker start async_aws_localstack-sns && exit 0 || \
docker pull localstack/localstack:0.14.2 && \
docker run -d -p 4573:4566 -e SERVICES=sns -v /var/run/docker.sock:/var/run/docker.sock --name async_aws_localstack-sns localstack/localstack:0.14.2 && \
docker pull localstack/localstack:3.0.0 && \
docker run -d -p 4573:4566 -e SERVICES=sns -v /var/run/docker.sock:/var/run/docker.sock --name async_aws_localstack-sns localstack/localstack:3.0.0 && \
docker run --rm --link async_aws_localstack-sns:localstack martin/wait -c localstack:4566

test: initialize
Expand Down

0 comments on commit df33cfb

Please sign in to comment.