Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · 8ed73fe · 8ed73fe
1 parent ae43fc5
commit 8ed73fe
Show file tree

Hide file tree

Showing 13 changed files with 16 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 2.1.2
 
 ### Changed

diff --git a/src/Input/DeleteParameterRequest.php b/src/Input/DeleteParameterRequest.php
@@ -57,6 +57,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonSSM.DeleteParameter',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/DeleteParametersRequest.php b/src/Input/DeleteParametersRequest.php
@@ -61,6 +61,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonSSM.DeleteParameters',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/GetParameterRequest.php b/src/Input/GetParameterRequest.php
@@ -79,6 +79,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonSSM.GetParameter',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/GetParametersByPathRequest.php b/src/Input/GetParametersByPathRequest.php
@@ -148,6 +148,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonSSM.GetParametersByPath',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/GetParametersRequest.php b/src/Input/GetParametersRequest.php
@@ -84,6 +84,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonSSM.GetParameters',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/PutParameterRequest.php b/src/Input/PutParameterRequest.php
@@ -367,6 +367,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonSSM.PutParameter',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/tests/Unit/Input/DeleteParameterRequestTest.php b/tests/Unit/Input/DeleteParameterRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             X-Amz-Target: AmazonSSM.DeleteParameter
+            Accept: application/json
 
             {
                 "Name": "EC2DevServerType"

diff --git a/tests/Unit/Input/DeleteParametersRequestTest.php b/tests/Unit/Input/DeleteParametersRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             X-Amz-Target: AmazonSSM.DeleteParameters
+            Accept: application/json
 
             {
                 "Names": [

diff --git a/tests/Unit/Input/GetParameterRequestTest.php b/tests/Unit/Input/GetParameterRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             X-Amz-Target: AmazonSSM.GetParameter
+            Accept: application/json
 
             {
                 "Name": "MyGitHubPassword"

diff --git a/tests/Unit/Input/GetParametersByPathRequestTest.php b/tests/Unit/Input/GetParametersByPathRequestTest.php
@@ -19,6 +19,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             X-Amz-Target: AmazonSSM.GetParametersByPath
+            Accept: application/json
 
             {
                 "Path": "/Branch312/Dev/",

diff --git a/tests/Unit/Input/GetParametersRequestTest.php b/tests/Unit/Input/GetParametersRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
         POST / HTTP/1.0
         Content-Type: application/x-amz-json-1.1
             X-Amz-Target: AmazonSSM.GetParameters
+            Accept: application/json
 
         {
             "Names": [

diff --git a/tests/Unit/Input/PutParameterRequestTest.php b/tests/Unit/Input/PutParameterRequestTest.php
@@ -23,6 +23,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             X-Amz-Target: AmazonSSM.PutParameter
+            Accept: application/json
 
             {
                 "Overwrite": true,