-
Notifications
You must be signed in to change notification settings - Fork 2
Basic !!should functionality added #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| { | ||
| $this->choice = $choice; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra newline
| { | ||
| $this->reply = $reply; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra newline
| { | ||
| return (new ShouldIHandler())->should($choice1, $choice2); | ||
| } | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add newline and remove docblock
|
|
||
| final class Plugin | ||
| { | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove docblock
| namespace AsyncBot\Plugin\ShouldI; | ||
| use AsyncBot\Plugin\ShouldI\ValueObject\Result\ShouldI; | ||
| use AsyncBot\Plugin\ShouldI\ValueObject\Result\Is; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two newlines
| return 'banana'; | ||
| }, $text); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove newline
|
|
||
| return new ShouldI($answer); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra newline
| private function translatePronouns(string $text): string | ||
| { | ||
| static $replacePairs = [ | ||
| 'iyou' => ['i', 'you'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align all ze =>
| { | ||
| public function should(string $choice1, string $choice2): ShouldI | ||
| { | ||
| $yes = $choice1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align equals signs
| { | ||
| return self::RESPONSES[$answer][random_int(0, (count(self::RESPONSES[$answer]) - 1))]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove newline
No description provided.