Skip to content

Fix generix type declaration #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

Khartir
Copy link
Contributor

@Khartir Khartir commented Nov 30, 2019

Description

Closes #227. Iirc the T extends {} was just a quick fix for the problem TS has parsing generic arrow functions in JSX files. @phryneas do you agree?

Breaking changes

None

Checklist

  • Updated the TypeScript type definitions

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 129385c:

Sandbox Source
mutable-sky-b54xf Configuration
React Typescript Issue #227

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #229 into next will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #229      +/-   ##
==========================================
- Coverage   98.59%   98.58%   -0.01%     
==========================================
  Files           8        8              
  Lines         426      424       -2     
  Branches      140      140              
==========================================
- Hits          420      418       -2     
  Misses          6        6
Impacted Files Coverage Δ
packages/react-async/src/useAsync.tsx 99.23% <100%> (-0.01%) ⬇️
packages/react-async/src/Async.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8544f...129385c. Read the comment docs.

@ghengeveld
Copy link
Member

Excellent! Thanks for the quick fix! We can ship this with v10.

@ghengeveld ghengeveld merged commit 2488924 into async-library:next Nov 30, 2019
@Khartir Khartir deleted the fix-generic-type branch November 30, 2019 13:53
@phryneas
Copy link
Member

If it works, thumbs up 👍 otherwise, we could have extended unknown instead, but this is even better. Thansk!

@ghengeveld ghengeveld mentioned this pull request Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useAsync T cannot be null
3 participants