Export Props interfaces to allow exported declarations

[nealeu]

Otherwise we get:

TS4023: Exported variable 'MyAsync' has or is using name 'PendingProps' from external module "/node_modules/react-async/dist-types/index" but cannot be named.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ffaab2:

Sandbox	Source
still-tdd-pj359	Configuration

[codecov]

Codecov Report

Merging #236 into next will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #236   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files           8        8           
  Lines         424      424           
  Branches      148      148           
=======================================
  Hits          418      418           
  Misses          6        6

Impacted Files	Coverage Δ
packages/react-async/src/Async.tsx	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1351fd0...5ffaab2. Read the comment docs.

[phryneas]

It wouldn't hurt exposing those, so we can definitely do that.

But could you please share in which scenario you need those? Are you creating your own library with declarations wrapping react-async? Just for usage, I believe this would not be neccessary.

[nealeu]

Thanks for the feedback @phryneas.

I've got a monorepo where we're using Typescript project references and incremental builds which therefore generate declaration files.

I've decided to separate the Async from the promiseFn, such that components can consume an Async without the implementation of the fetch also being in that library. This allows us to build our components independently of the data source (which could be IndexedDB or a remote system).

So we have the following code in AsyncSessionData.tsx:

export const AsyncSessionData = createInstance<Context>({}, "SessionData");

Which results in the following in AsyncSessionData.d.ts:

export declare const AsyncSessionData: import("react-async").AsyncConstructor<Context>;

Which my previous PR would have solved had it not been that AsyncConstructor uses PendingProps etc.

I've now got this behaving as needed with the exports in this PR

[phryneas]

Okay, that seems like a sensible use case.
Usually, I'm a bit against exposing too many internal types, as it gets in the way of refactoring without causing breaking changes, but this seems good from my side. :)

I take it you validated the codesandbox build now checks all your requirements? :)

[nealeu]

I take it you validated the codesandbox build now checks all your requirements? :)

Yes. Currently have our build running successfully against the sandbox build for this PR.

[ghengeveld]

LGTM. It'll mean we have to do a major release when changing any of these, but I suspect that would be the case anyway.

[ghengeveld]

@all-contributors please add @nealeu for code.

[allcontributors]

@ghengeveld

I've put up a pull request to add @nealeu! 🎉