feat: add initial support for pollcatch #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
r? @rcoh |
rcoh
approved these changes
Apr 16, 2025
Comment on lines
+81
to
+83
| { | ||
| rt.on_before_task_poll(|_| async_profiler_agent::pollcatch::before_poll_hook()) | ||
| .on_after_task_poll(|_| async_profiler_agent::pollcatch::after_poll_hook()); |
Collaborator
There was a problem hiding this comment.
this has to be set in the builder right?
| } | ||
| } | ||
|
|
||
| impl super::profiler::ProfilerEngine for AsProf { |
Collaborator
There was a problem hiding this comment.
AsProf — I assume this means AsyncProfiler but since As is an english word common in Rust this is a bit confusing. Consider renaming to AsyncProfiler
Collaborator
Author
There was a problem hiding this comment.
this was copied from the previous agent. I can rename.
Comment on lines
+25
to
+32
| #[cfg(not(any( | ||
| all(target_arch = "x86_64", target_feature = "sse2"), | ||
| target_arch = "aarch64", | ||
| )))] | ||
| #[inline] | ||
| fn _now() -> u64 { | ||
| 0 | ||
| } |
Collaborator
There was a problem hiding this comment.
can we emit a deprecation in this case? Or some sort of warning?
Collaborator
Author
There was a problem hiding this comment.
the general sense is that async-profiler only support x86 and ARM anyway
Comment on lines
+40
to
+42
| pub fn main() -> anyhow::Result<()> { | ||
| let mut rt: tokio::runtime::Builder = tokio::runtime::Builder::new_multi_thread(); | ||
| rt.enable_all(); |
Collaborator
There was a problem hiding this comment.
can you file an issue for turning an example into an integration test that we can run to validate future changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request