Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<TcpStream as Write>::poll_close does nothing #599

Closed
twittner opened this issue Nov 29, 2019 · 1 comment · Fixed by #618
Closed

<TcpStream as Write>::poll_close does nothing #599

twittner opened this issue Nov 29, 2019 · 1 comment · Fixed by #618
Labels
bug Something isn't working enhancement New feature or request

Comments

@twittner
Copy link
Contributor

It seems that <TcpStream as Write>::poll_close calls <&TcpStream as Write>::poll_close which is a no-op. Would it not be more appropriate to shutdown the write direction of the socket, i.e. call TcpStream::shutdown with std::net::Shutdown::Write? Otherwise two processes that wait on each others EOF will wait forever.
@yoshuawuyts yoshuawuyts added bug Something isn't working enhancement New feature or request labels Dec 12, 2019
@yoshuawuyts
Copy link
Contributor

@twittner what you're suggesting seems reasonable; if you have the time, a patch for this would be greatly appreciated!

twittner added a commit to twittner/async-std that referenced this issue Dec 12, 2019
@twittner
TcpStream: Shutdown write direction in poll_close.
c90732a 
Fixes async-rs#599.
@twittner twittner mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TcpStream: Shutdown write direction in poll_close. twittner/async-std
2 participants
@twittner @yoshuawuyts