Reduce dependency on futures crate #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 28, 2019 22:33
ghost
requested a review
from 
|
This is fails on travis is failing imports. |
yoshuawuyts
reviewed
Sep 3, 2019
| @@ -4,7 +4,9 @@ | |||
| pub use std::future::Future; | |||
|
|
|||
| pub use pending::pending; | |||
| pub use poll_fn::poll_fn; | |||
There was a problem hiding this comment.
This seems to depend on #124.
yoshuawuyts
approved these changes
Sep 4, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces our dependency on the futures crate by only keeping
futures-channel-preview,futures-core-preview, andfutures-io-previewas dependencies.The
futures-timercrate still pulls the wholefutures-previewcrate as a transitive dependency, so this PR is not yet the solution, but is a first step towards it.In the end, we'd like to depend only on
futures-core-previewandfutures-io-preview, only using traitsStream,AsyncRead,AsyncWrite, and nothing else.