Skip to content

add future::{join,try_join,select,try_select} macros #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2019
Merged

add future::{join,try_join,select,try_select} macros #187

merged 3 commits into from
Sep 24, 2019

Conversation

@yoshuawuyts
Copy link
Contributor

@yoshuawuyts yoshuawuyts commented Sep 12, 2019 •
edited
Loading

Adds the future::{join,try_join} macros. Depends on publishing a first release of https://github.com/async-rs/async-macros first (@stjepang could I get publish access to crates.io for async-macros?). Thanks!

Closes #14, #175.

Screenshot

This is what the docs look like:

Screenshot_2019-09-12 async_std future - Rust

@yoshuawuyts
Copy link
Contributor Author

Updated with select and try_select!

Screenshot_2019-09-14 async_std future - Rust

@yoshuawuyts yoshuawuyts changed the title add future::{join,try_join} macros add future::{join,try_join,select,try_select} macros Sep 14, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Sep 17, 2019
Closed
6 tasks
@yoshuawuyts
add future::{join,try_join} macros
4cbc319 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts
try_select, select
fb2d2e2 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts
use async-macros 1.0.0
b951cf2 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts mentioned this pull request Sep 17, 2019
Merged
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Sep 17, 2019
@yoshuawuyts yoshuawuyts marked this pull request as ready for review September 17, 2019 21:25
@yoshuawuyts yoshuawuyts requested a review from a user September 17, 2019 21:26
@yoshuawuyts
Copy link
Contributor Author

This PR is ready for review now that async-macros has been published! 🎉

This was referenced Sep 17, 2019
Merged
Open
bors bot added a commit that referenced this pull request Sep 19, 2019
@bors @yoshuawuyts
Merge #208
f45b39d 
208: add stream::join r=stjepang a=yoshuawuyts

Ref #129 #187. This adds the `stream::join` which can join multiple streams into a single stream. Thanks!

## Example
```rust
let a = stream::once(1u8);
let b = stream::once(2u8);
let c = stream::once(3u8);

let mut s = stream::join!(a, b, c);

assert_eq!(s.collect().await, vec![1u8, 2u8, 3u8]);
```

## Screenshot

![Screenshot_2019-09-17 async_std stream - Rust](https://user-images.githubusercontent.com/2467194/65080099-cedb8b00-d9a0-11e9-984f-edd7d6bad5cc.png)


Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts
Copy link
Contributor Author

We now have stream::join as module-level macro and marked as unstable. I think it should be okay to merge this to let people try this out in the next release. Thanks!

@yoshuawuyts yoshuawuyts merged commit 785371c into master Sep 24, 2019
@yoshuawuyts yoshuawuyts deleted the join-macros branch September 24, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Future::join

2 participants

@yoshuawuyts