feat: missing Read and Write methods #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
feat/more-io
branch
from
5a9ba53 to
e681e29
Compare
Member
Author
|
marking as ready, this can be reviewed and merged, and |
yoshuawuyts
reviewed
Sep 27, 2019
yoshuawuyts
reviewed
Sep 27, 2019
yoshuawuyts
approved these changes
Sep 27, 2019
Contributor
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
This is really thorough, and is looking 💯. I've left a few comments about some minor things, but overall this PR is great!
yoshuawuyts
approved these changes
Sep 28, 2019
Contributor
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
Sweet! Thanks so much!
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 28, 2019
245: feat: missing Read and Write methods r=yoshuawuyts a=dignifiedquire Ref: #131 - [x] Read::by_ref - [x] Read::bytes - [x] Read::chain - [x] Read::take - [ ] Write::by_ref - [ ] ~~Write::write_fmt~~ postponed until #247 is solved Needs fixing: - [x] `BufRead` for `Take` - [x] `BufRead` for `Chain` - [ ] `by_ref` conflict between `Read` and `Write`, unable to add both, as they conflict, and the current state of things does not allow to differentiate between the two. Co-authored-by: dignifiedquire <dignifiedquire@users.noreply.github.com>
Contributor
Build succeeded
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #131
Write::write_fmtpostponed until [tracking] fmt #247 is solvedNeeds fixing:
BufReadforTakeBufReadforChainby_refconflict betweenReadandWrite, unable to add both, as they conflict, and the current state of things does not allow to differentiate between the two.