Skip to content

Add task::yield_now as "unstable" #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 14, 2019
Merged

Add task::yield_now as "unstable" #300

1 commit merged into from
Oct 14, 2019

Conversation

yoshuawuyts
Copy link
Contributor

@yoshuawuyts yoshuawuyts commented Oct 9, 2019 •
edited
Loading

Closes #290. Thanks!

Screenshots

Screenshot_2019-10-10 async_std task yield_now - Rust(1)

@yoshuawuyts
implement task::yield_now
b665ab3 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 9, 2019
@yoshuawuyts
Copy link
Contributor Author

As was pointed out to me on Twitter, there's prior art for this function in Node's setimmediate call.

@yoshuawuyts yoshuawuyts changed the title implement task::yield_now Add task::yield_now as "unstable" Oct 13, 2019
@yoshuawuyts yoshuawuyts added this to the 0.99.10 milestone Oct 13, 2019
ghost
ghost approved these changes Oct 14, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghost ghost merged commit d6aa1fb into master Oct 14, 2019
@ghost ghost deleted the yield-now branch October 14, 2019 11:58
@chpio
Copy link

chpio commented Oct 16, 2019

could this clash with a "message passing optimization"?

@ghost
Copy link

ghost commented Oct 16, 2019

@chpio not really, we can still do all kinds of optimizations :)

@yoshuawuyts yoshuawuyts mentioned this pull request Jul 14, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.99.10
Development

Successfully merging this pull request may close these issues.

[discussion] Add task::yield_now()?
2 participants
@yoshuawuyts @chpio