Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BufWriter::into_inner flush #315

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Add BufWriter::into_inner flush #315

merged 2 commits into from
Oct 13, 2019

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Oct 13, 2019

close: #313

yoshuawuyts
yoshuawuyts approved these changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 28b0ebe into async-rs:master Oct 13, 2019
@k-nasa k-nasa deleted the add_flush_to_into_inner branch October 13, 2019 13:28
@yoshuawuyts yoshuawuyts added this to the 0.99.10 milestone Oct 13, 2019
@taiki-e taiki-e mentioned this pull request Oct 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.99.10
Development

Successfully merging this pull request may close these issues.

BufWriter::into_inner doesn't flush
2 participants
@k-nasa @yoshuawuyts